Add update_encoder to target proxy compute resources #17733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hamza Hassan <hamzahassan@google.com> [upstream:6512a3d1c9e6e85e222e072af9d850772fa709d9] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add update_encoder to
ComputeTargetHttpsProxyandComputeRegionTargetHttpsProxyresources.In case a customer changes the field certificate_manager_certificate, the encoder logic does not get applied. I fixed this by using
update_encoderwhich is the same as the encoder.The reason that encoder is not applied during the update might relate to the fact that those resources are immutable, though there is a field-specific-update that overrides this (see the YAQ question below)
Fixes: /issues/17641
yaqs/2098594962982567936
b/329516022
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10261