Add support for the Internal Ranges API

[daanheikens]

Fixes: hashicorp/terraform-provider-google#14698

Release Note Template for Downstream PRs (will be copied)

google_network_connectivity_internal_range

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1380 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1380 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 156 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 476 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_internal_range (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_internal_range" "primary" {
  effective_labels = # value needed
  project          = # value needed
  terraform_labels = # value needed
  users            = # value needed
}

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 7
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample[Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample[Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Couple notes on tests, the resource code itself looks good so far!

[daanheikens]

Couple notes on tests, the resource code itself looks good so far!

Thanks @rileykarson i will have a look at it!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1481 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1481 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 156 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 476 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_internal_range (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_internal_range" "primary" {
  effective_labels = # value needed
  project          = # value needed
  terraform_labels = # value needed
  users            = # value needed
}

[rileykarson]

(I think that message is wrong, I'll let you know if it's not during my next full pass)

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 10
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample[Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1551 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1551 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 156 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 476 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_internal_range (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_internal_range" "primary" {
  project = # value needed
}

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rileykarson]

LGTM, thank you!