-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Internal Ranges API #10465
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_internal_range" "primary" {
effective_labels = # value needed
project = # value needed
terraform_labels = # value needed
users = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple notes on tests, the resource code itself looks good so far!
Thanks @rileykarson i will have a look at it! |
Add update test
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_internal_range" "primary" {
effective_labels = # value needed
project = # value needed
terraform_labels = # value needed
users = # value needed
}
|
(I think that message is wrong, I'll let you know if it's not during my next full pass) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample|TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_internal_range" "primary" {
project = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Fixes: hashicorp/terraform-provider-google#14698
Release Note Template for Downstream PRs (will be copied)