-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Dataplex Aspect Type resource. #10741
Adding support for Dataplex Aspect Type resource. #10741
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type" "primary" {
metadata_template = # value needed
}
Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectTypeIamBindingGenerated|TestAccDataplexAspectTypeIamMemberGenerated|TestAccDataplexAspectTypeIamPolicyGenerated|TestAccDataplexAspectType_dataplexAspectTypeBasicExample|TestAccDataplexAspectType_dataplexAspectTypeFullExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectType_update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a few nits, and the test should be changed
mmv1/third_party/terraform/services/dataplex/resource_dataplex_aspect_type_test.go
Outdated
Show resolved
Hide resolved
…GoogleCloudPlatform#10713) Co-authored-by: Lauren Huang <laurenhuang@google.com>
…ogleCloudPlatform#10722) Co-authored-by: Tommy Lang <tommylang@google.com>
…uration feature on Beta (GoogleCloudPlatform#10683) Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
…drunv2ServiceWithDirectVPCUpdate (GoogleCloudPlatform#10739)
Co-authored-by: pweiber <periclesweiber@ciandt.com>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_aspect_type_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_dataplex_aspect_type_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexAspectType_update |
|
Closing in favor of #10751 |
Adding Terraform support for a Dataplex Aspect Type resource.
Tracking issue: hashicorp/terraform-provider-google#18147