Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Organization, folder and project Mute Config #10772

Closed

Conversation

Copy link

google-cla bot commented May 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge May 23, 2024 03:27
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/securitycenter and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+))
google-beta provider: Diff ( 3 files changed, 156 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterV2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterFolderMuteConfig_basic
  • TestAccSecurityCenterOrganizationMuteConfig_basic
  • TestAccSecurityCenterProjectMuteConfig_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 24, 2024
@github-actions github-actions bot requested a review from trodge May 25, 2024 04:01
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 25, 2024
Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 28, 2024
@github-actions github-actions bot requested a review from trodge May 28, 2024 22:19
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 28, 2024
@github-actions github-actions bot requested a review from trodge May 29, 2024 00:21
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 29, 2024
@github-actions github-actions bot requested a review from trodge July 14, 2024 23:56
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 14, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 15, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2598 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2588 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  project_parent = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderMuteConfig_basic
  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_basic
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 15, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2631 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2621 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  project_parent = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete
  • TestAccSecurityCenterV2FolderMuteConfig_basic
  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 15, 2024
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 17, 2024
Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@@ -51,13 +51,6 @@ parameters:
default_value: global
description: |
location Id is provided by organization. If not provided, Use global as default.
- !ruby/object:Api::Type::String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this field being removed?

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 18, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1808 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 12 files changed, 1798 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field mute_config_id within resource google_scc_v2_organization_mute_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  project_parent = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 2
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2FolderMuteConfig_basic
  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_update
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterV2FolderMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_update[Error message] [Debug log]
TestAccSecurityCenterV2ProjectMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

github-actions bot commented Aug 1, 2024

@thokalavinod, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

@thokalavinod
Copy link
Contributor Author

This PR is created as seperate files, So I am closing this PR.

@github-actions github-actions bot requested a review from trodge August 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants