Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Organization, folder and project Mute Config #10772

Open
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

Copy link

google-cla bot commented May 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge May 23, 2024 03:27
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/securitycenter and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+))
google-beta provider: Diff ( 3 files changed, 156 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterV2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterFolderMuteConfig_basic
  • TestAccSecurityCenterOrganizationMuteConfig_basic
  • TestAccSecurityCenterProjectMuteConfig_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 24, 2024
@github-actions github-actions bot requested a review from trodge May 25, 2024 04:01
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 25, 2024
Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 28, 2024
@github-actions github-actions bot requested a review from trodge May 28, 2024 22:19
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 28, 2024
@github-actions github-actions bot requested a review from trodge May 29, 2024 00:21
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2602 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 2592 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3794
Passed tests: 3405
Skipped tests: 381
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccSecurityCenterV2FolderMuteConfig_basic|TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample|TestAccSecurityCenterV2OrganizationMuteConfig_basic|TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample|TestAccSecurityCenterV2ProjectMuteConfig_basic|TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 13, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2598 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 2588 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_folder_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_folder_mute_config" "primary" {
  parent = # value needed
}

Resource: google_scc_v2_organization_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_mute_config" "primary" {
  parent = # value needed
}

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  parent = # value needed
}

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 13, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3795
Passed tests: 3406
Skipped tests: 381
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccSecurityCenterV2FolderMuteConfig_basic|TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample|TestAccSecurityCenterV2OrganizationMuteConfig_basic|TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample|TestAccSecurityCenterV2ProjectMuteConfig_basic|TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 14, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 2634 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderMuteConfig_basic
  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_basic
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 14, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 2634 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  project_parent = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3800
Passed tests: 3410
Skipped tests: 381
Affected tests: 9

Click here to see the affected service packages
all service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccFolderIamPolicy_basic|TestAccLoggingBucketConfigOrganization_basic|TestAccSecurityCenterV2FolderMuteConfig_basic|TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample|TestAccSecurityCenterV2OrganizationMuteConfig_basic|TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample|TestAccSecurityCenterV2ProjectMuteConfig_basic|TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

immutable: true
url_param_only: true
description: |
Resource name of the new organization mute configs's parent. Its format is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be simpler to add the folders/ part to the url and remove it from this field. That way the field doesn't need to preserve a forward slash in its value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@github-actions github-actions bot requested a review from trodge June 19, 2024 20:06
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2644 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 2634 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_mute_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  project_parent = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3811
Passed tests: 3419
Skipped tests: 383
Affected tests: 9

Click here to see the affected service packages
all service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccLoggingBucketConfigOrganization_basic|TestAccSecurityCenterV2FolderMuteConfig_basic|TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample|TestAccSecurityCenterV2OrganizationMuteConfig_basic|TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample|TestAccSecurityCenterV2ProjectMuteConfig_basic|TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectMuteConfig_basic[Error message] [Debug log]
TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants