-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource Organization, folder and project Mute Config #10772
Add Resource Organization, folder and project Mute Config #10772
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Click here to see the affected service packages
Non-exercised testsTests were added that are skipped in VCR:
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
mmv1/templates/terraform/examples V2/scc_folder_mute_config_basic.tf.erb
Outdated
Show resolved
Hide resolved
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
...d_party/terraform/services/securitycenterv2/resource_scc_v2_organization_mute_config_test.go
Outdated
Show resolved
Hide resolved
.../third_party/terraform/services/securitycenterv2/resource_scc_v2_project_mute_config_test.go
Show resolved
Hide resolved
.../third_party/terraform/services/securitycenterv2/resource_scc_v2_project_mute_config_test.go
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_project_mute_config" "primary" {
project_parent = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_project_mute_config" "primary" {
project_parent = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@@ -51,13 +51,6 @@ parameters: | |||
default_value: global | |||
description: | | |||
location Id is provided by organization. If not provided, Use global as default. | |||
- !ruby/object:Api::Type::String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this field being removed?
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_project_mute_config" "primary" {
project_parent = # value needed
}
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@thokalavinod, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. If no action is taken, this PR will be closed in 28 days. This notification can be disabled with the |
This PR is created as seperate files, So I am closing this PR. |
Related to http://b/330538229.
Issue No: https://b.corp.google.com/issues/339717598
Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.muteConfigs
https://cloud.google.com/security-command-center/docs/reference/rest/v1/organizations.muteConfigs
https://cloud.google.com/security-command-center/docs/reference/rest/v1/projects.muteConfigs