-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation notice for require_ssl field #10797
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange |
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
Friendly ping. Thanks. |
Related to issues/17443. Basically customers need to manually set compatible
require_ssl
andssl_mode
otherwise the request will fail. Therequire_ssl
is legacy and its functionality can be fully replaced byssl_mode
.To get rid of the burden, we have to deprecate the
require_ssl
in favor of the newer fieldssl_mode
. This PR adds the deprecation message for the fieldrequire_ssl
.Release Note Template for Downstream PRs (will be copied)