Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6.0.0 upgrade guide for the deprecated require_ssl field. #10833

Merged
merged 1 commit into from
May 30, 2024

Conversation

feng-zhe
Copy link
Contributor

Following the deprecation guide to add the upgrade entry for the deprecated require_ssl which will be removed in 6.0.0.

Release Note Template for Downstream PRs (will be copied)

Add upgrade guide for the deprecated `require_ssl` field which will be removed in 6.0.0.

@github-actions github-actions bot requested a review from rileykarson May 30, 2024 00:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 7 insertions(+), 1 deletion(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- deprecated in a separate PR in #10797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants