Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCR acc test fixes #3586

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 30, 2020

Even more test fixes!

Getting a service account via getTestServiceAccountFromEnv skips the test depending on environment variables set. If this happens after we use a VCR-seeded random function (randString, etc) the test will attempt to read the seed file which never gets written because the test never passed. Putting getTestServiceAccountFromEnv first causes the tests to skip correctly

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 12 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 7 files changed, 15 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 14 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 17 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 16 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 9 files changed, 19 insertions(+), 4 deletions(-))

@slevenick slevenick changed the title Test commit VCR acc test fixes Jun 1, 2020
@slevenick slevenick requested a review from danawillow June 1, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants