VCR acc test fixes #6507
Merged
VCR acc test fixes #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test commit * Test commit * Fix a couple more tests * Wrong method name * Fix more tests * Ordering of getting service account * Skip fine-grained test * Skip iam test with fine-grained Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
the
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more test fixes!
Getting a service account via
getTestServiceAccountFromEnvskips the test depending on environment variables set. If this happens after we use a VCR-seeded random function (randString, etc) the test will attempt to read the seed file which never gets written because the test never passed. PuttinggetTestServiceAccountFromEnvfirst causes the tests to skip correctlyRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3586