Add new Resource Cloudids Endpoint #6617

hao-nan-li · 2022-09-28T22:20:36Z

Add new Resource Cloudids Endpoint

Fixed hashicorp/terraform-provider-google#10694

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2022-09-28T22:21:35Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-09-28T22:32:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 850 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 850 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-09-28T22:34:55Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

c2thorn · 2022-09-29T15:53:13Z

@hao-nan-li, another signal you can make for WIP PR's is to "Convert to draft". This blocks the PR from being merged as well

hao-nan-li · 2022-09-29T16:27:02Z

@hao-nan-li, another signal you can make for WIP PR's is to "Convert to draft". This blocks the PR from being merged as well

Thanks for the hint, will do. I originally thought this PR is ready for review until this unexpected error happens.

modular-magician · 2022-09-29T16:50:28Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 965 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 965 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 124 insertions(+))

modular-magician · 2022-09-29T17:58:29Z

Tests analytics

Total tests: 2193
Passed tests 1938
Skipped tests: 240
Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeRouterInterface_basic|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccCloudIdsEndpoint_cloudidsEndpointExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_update

modular-magician · 2022-09-29T18:30:49Z

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Error message] [Debug log]
TestAccComputeRouterInterface_basic[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccCloudIdsEndpoint_cloudidsEndpointExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-30T17:18:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 886 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 886 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-09-30T17:32:02Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 886 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 886 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-09-30T18:24:25Z

Tests analytics

Total tests: 2193
Passed tests 1950
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade

modular-magician · 2022-09-30T18:56:54Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/cloudids/api.yaml

mmv1/products/cloudids/terraform.yaml

mmv1/products/cloudids/api.yaml

mmv1/third_party/terraform/tests/resource_cloudids_endpoint_test.go

…y fields

modular-magician · 2022-10-03T16:57:22Z

Hi there, I'm the Modular magician - !

Diff report

Terraform GA: Diff ( 7 files changed, 888 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 888 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-03T17:35:54Z

Tests analytics

Total tests: 2197
Passed tests 1954
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-03T23:05:55Z

Hi there, I'm the Modular magician - !

Diff report

Terraform GA: Diff ( 7 files changed, 815 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 815 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-03T23:53:26Z

Tests analytics

Total tests: 2199
Passed tests 1956
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudIdsEndpoint_basic|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample

modular-magician · 2022-10-03T23:55:50Z

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2022-10-04T17:17:42Z

/gcbrun

modular-magician · 2022-10-04T17:31:19Z

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 7 files changed, 815 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 815 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-04T18:23:03Z

Tests analytics

Total tests: 2201
Passed tests 1957
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCloudIdsEndpoint_basic|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-04T18:28:29Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-05T16:59:32Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-05T17:43:10Z

Tests analytics

Total tests: 2202
Passed tests 1959
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudIdsEndpoint_basic

modular-magician · 2022-10-05T17:48:23Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2022-10-05T18:25:04Z

/gcbrun

modular-magician · 2022-10-05T18:39:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-05T19:23:00Z

Tests analytics

Total tests: 2203
Passed tests 1960
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudIdsEndpoint_basic

modular-magician · 2022-10-05T19:25:24Z

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2022-10-07T16:51:40Z

/gcbrun

modular-magician · 2022-10-07T17:04:46Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-07T17:54:44Z

Tests analytics

Total tests: 2208
Passed tests 1964
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudIdsEndpoint_basic|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-07T17:59:09Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2022-10-07T18:08:29Z

/gcbrun

modular-magician · 2022-10-07T18:21:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 816 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 100 insertions(+), 3 deletions(-))

modular-magician · 2022-10-07T19:10:59Z

Tests analytics

Total tests: 2208
Passed tests 1964
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccCloudIdsEndpoint_basic|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-07T19:33:52Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudIdsEndpoint_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li added 5 commits September 26, 2022 14:53

[WIP] Add cloud_ids endpoint resource and creation tests

8058f73

[WIP] cloud ids -- Fix errors on resource creation

267aeac

Cloud ids endpoint -- Fix creation test

80d7388

Cloud ids Endpoint -- Add an example .erb file

4596a06

Clean formatting of the test file

6391cd0

modular-magician requested a review from c2thorn September 28, 2022 22:21

hao-nan-li changed the title ~~Add new Resource Cloudids Endpoint~~ [WIP] Add new Resource Cloudids Endpoint Sep 28, 2022

hao-nan-li marked this pull request as draft September 29, 2022 16:27

Remove skip-test flag to generate {resource}_generated_test file

8e56b75

hao-nan-li changed the title ~~[WIP] Add new Resource Cloudids Endpoint~~ Add new Resource Cloudids Endpoint Sep 29, 2022

hao-nan-li marked this pull request as ready for review September 29, 2022 18:57

Add skip-test flag back, add destroy function to the test file

9ca3074

Fix make lint problem

54d9381

c2thorn requested changes Sep 30, 2022

View reviewed changes

Cloud Ids -- Update comments on skip_test, add input:true to necessar…

2703667

…y fields

modular-magician requested a review from c2thorn October 3, 2022 16:46

Change API wait time from 1000ms to 2000ms

fb91948

c2thorn approved these changes Oct 7, 2022

View reviewed changes

c2thorn merged commit e75323f into GoogleCloudPlatform:main Oct 7, 2022

This was referenced Oct 7, 2022

Add new Resource Cloudids Endpoint hashicorp/terraform-provider-google-beta#4765

Merged

Add new Resource Cloudids Endpoint hashicorp/terraform-provider-google#12744

Merged

Add new Resource Cloudids Endpoint GoogleCloudPlatform/terraform-validator#1035

Merged

roaks3 mentioned this pull request Dec 14, 2022

Failing test(s): Error code 9, message: encountered some transient internal error, please try again later hashicorp/terraform-provider-google#12902

Closed

melinath mentioned this pull request Jan 10, 2023

resource google_cloud_ids_endpoint hashicorp/terraform-provider-google#10694

Closed

Add new Resource Cloudids Endpoint #6617

Add new Resource Cloudids Endpoint #6617

Conversation

hao-nan-li commented Sep 28, 2022 • edited by melinath

modular-magician commented Sep 28, 2022

modular-magician commented Sep 28, 2022

Diff report:

modular-magician commented Sep 28, 2022

Tests analytics

c2thorn commented Sep 29, 2022

hao-nan-li commented Sep 29, 2022 • edited

modular-magician commented Sep 29, 2022

Diff report:

modular-magician commented Sep 29, 2022

Tests analytics

Action taken

modular-magician commented Sep 29, 2022

modular-magician commented Sep 30, 2022

Diff report:

modular-magician commented Sep 30, 2022

Diff report:

modular-magician commented Sep 30, 2022

Tests analytics

Action taken

modular-magician commented Sep 30, 2022

modular-magician commented Oct 3, 2022

Diff report

modular-magician commented Oct 3, 2022

Tests analytics

Action taken

modular-magician commented Oct 3, 2022

Diff report

modular-magician commented Oct 3, 2022

Tests analytics

Action taken

modular-magician commented Oct 3, 2022

hao-nan-li commented Oct 4, 2022

modular-magician commented Oct 4, 2022

Diff report

modular-magician commented Oct 4, 2022

Tests analytics

Action taken

modular-magician commented Oct 4, 2022

modular-magician commented Oct 5, 2022

Diff report:

modular-magician commented Oct 5, 2022

Tests analytics

Action taken

modular-magician commented Oct 5, 2022

hao-nan-li commented Oct 5, 2022

modular-magician commented Oct 5, 2022

Diff report:

modular-magician commented Oct 5, 2022

Tests analytics

Action taken

modular-magician commented Oct 5, 2022

hao-nan-li commented Oct 7, 2022

modular-magician commented Oct 7, 2022

Diff report:

modular-magician commented Oct 7, 2022

Tests analytics

Action taken

modular-magician commented Oct 7, 2022

hao-nan-li commented Oct 7, 2022

modular-magician commented Oct 7, 2022

Diff report:

modular-magician commented Oct 7, 2022

Tests analytics

Action taken

modular-magician commented Oct 7, 2022

hao-nan-li commented Sep 28, 2022 •

edited by melinath

hao-nan-li commented Sep 29, 2022 •

edited