Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Resource Cloudids Endpoint #6617
Add new Resource Cloudids Endpoint #6617
Changes from 8 commits
8058f73
267aeac
80d7388
4596a06
6391cd0
8e56b75
9ca3074
54d9381
2703667
9b7e3d0
9af7924
fb91948
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I missed this before, but I was trying to find the VCR test result for this test. I think it isn't running because the function wasn't named "TestAcc"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will do. Note that this test takes about 20 minutes to run locally. I'm slightly worried this will make VCR-test run time longer in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should only be a problem when it replays in recording mode.
Seeing the tenancy issue, you can try the BootStrapSharedTestNetwork, but if it won't work, we can skip this in VCR (with skipIfVCR) for now (with a confirmation that it works in locally in your own project)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll just re-run it both locally and on Github to make sure the current behaviour is consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the behaviour is consistent. Locally, if I set the resource to input:true, I'm also getting some unexpected behaviour. We can talk about this during our 1-1.