Add remaining default_route_action subfields to google_compute_region_url_map resource

[SarahFrench]

This PR adds the remaining defaultRouteAction.* fields that aren't in the first PR (#6674)

The new fields:

Field name	API documentation	Where this is defined for global version of this resource
defaultRouteAction.urlRewrite	API docs	Link to code
defaultRouteAction.corsPolicy	API docs	Link to code
defaultRouteAction.faultInjectionPolicy	API docs	Link to code
defaultRouteAction.timeout	API docs	Link to code

NOTE: This PR (and previous PR) do not implement the defaultRouteAction.maxStreamDuration field, because this is currently missing from the global url map resource. I'm aiming to get parity between the two url map resources, not necessarily 100% coverage of this field.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `default_route_action.url_rewrite` field to `google_compute_region_url_map` resource

compute: added `default_route_action.cors_policy` field to `google_compute_region_url_map` resource

compute: added `default_route_action.fault_injection_policy` field to `google_compute_region_url_map` resource

compute: added `default_route_action.timeout` field to `google_compute_region_url_map` resource

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[SarahFrench]

This PR is still in draft, and would ideally be rebased after this PR (#6674) gets merged first

Removing reviewers while this is in draft

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 3277 insertions(+), 1115 deletions(-))
Terraform Beta: Diff ( 3 files changed, 3277 insertions(+), 1115 deletions(-))
TF Validator: Diff ( 3 files changed, 656 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 242 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2216
Passed tests 1973
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[SarahFrench]

Just rebased this PR, following the first PR being updated (since this PR was opened) and being merged into main

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 1031 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1031 insertions(+), 46 deletions(-))
TF Validator: Diff ( 3 files changed, 323 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2251
Passed tests 2006
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_labels

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]

All tests passed
View the build log or the debug log for each test

[rileykarson]

This is still in draft, just confirming you want a review pass done now? I see it was used to mark it wasn't ready for review above, but the criteria to move forward appears to have been met.

Also, you can remove automatic assignment for yourself by adding your username to the list on

magic-modules/.ci/containers/contributor-checker/check-contributor.sh

Line 19 in d2eceed

if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1); then

if you'd like!

[SarahFrench]

Hi, sorry no I don't want a review now - the PR needs some edits so I left it in draft and forgot to remove the auto-assigned reviewer. I'll add myself to that list, thank you!

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 1055 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1055 insertions(+), 46 deletions(-))
TF Validator: Diff ( 3 files changed, 323 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2254
Passed tests 2011
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[SarahFrench]

Updated the handwritten test with the new fields, but excluded default_route_action.cors_policy. allow_origin_regexes because it has an API error in this test due to this restriction:

Regular expressions can only be used when the loadBalancingScheme is set to INTERNAL_SELF_MANAGED.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1098 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1098 insertions(+), 46 deletions(-))
TF Validator: Diff ( 3 files changed, 323 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2254
Passed tests 2012
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionUrlMap_defaultRouteAction_full_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]

All tests passed
View the build log or the debug log for each test

[SarahFrench]

I think this PR is ready for review now - I've made the new field match the global version of the resource (linked in PR description) and the test has been updated. The test omits one field as it requires a specific load balancer config (see here).

[ScottSuarez]

A few configuration asks and one test fix ask.

[ScottSuarez]

I worry about server side validation breaking this in the future since they aren't valid hosts/prefixes.

[SarahFrench]

Yeah that's a fair worry! I've replaced these values in 7613ca4

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1121 insertions(+), 68 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1121 insertions(+), 68 deletions(-))
TF Validator: Diff ( 3 files changed, 323 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 46 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2264
Passed tests 2014
Skipped tests: 241
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeUrlMap_trafficDirectorPathUpdate[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate[Debug log]
TestAccComputeUrlMap_urlMapTrafficDirectorPathExample[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]

All tests passed
View the build log or the debug log for each test

[ScottSuarez]

Small test modification request but approved otherwise.

[ScottSuarez]

Similar comment regarding prefix and host rewrites

[SarahFrench]

Thanks! I've updated all the instances of these fields across all the url map resources' tests. As the tests have passed I'll go ahead and merge.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1137 insertions(+), 84 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1137 insertions(+), 84 deletions(-))
TF Validator: Diff ( 3 files changed, 323 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 46 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2268
Passed tests 2018
Skipped tests: 243
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeUrlMap_defaultRouteActionUrlRewrite|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeRegionUrlMap_ilbPathUpdate

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeUrlMap_trafficDirectorPathUpdate[Debug log]
TestAccComputeUrlMap_defaultRouteActionUrlRewrite[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate[Debug log]
TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]

All tests passed
View the build log or the debug log for each test