Add 3 `default_route_action` subfields to `google_compute_region_url_map` resource #6674

SarahFrench · 2022-10-10T21:14:54Z

Closes hashicorp/terraform-provider-google#10660

This PR adds multiple new fields to the RegionUrlMap resource:

I've added the other fields under defaultRouteAction, but wanted to split the work across 2 PRs so it was easier to review

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `default_route_action.weighted_backend_services` field to `google_compute_region_url_map` resource

compute: added `default_route_action.retry_policy` field to `google_compute_region_url_map` resource

compute: added `default_route_action.request_mirror_policy` field to `google_compute_region_url_map` resource

modular-magician · 2022-10-10T21:15:59Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-10-10T21:17:34Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

…_region_url_map` resource Enforce mutual exclusive relationships between `defaultRouteAction.weightedBackendServices[]`, `defaultUrlRedirect` and `defaultService`

…uding `defaultRouteAction.weightedBackendServices[]`

…p` resource, update generated test

…n_url_map` resource, update generated test

modular-magician · 2022-10-10T21:32:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 1227 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1227 insertions(+), 50 deletions(-))
TF Validator: Diff ( 3 files changed, 336 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 202 insertions(+))

modular-magician · 2022-10-10T22:18:01Z

Tests analytics

Total tests: 2209
Passed tests 1963
Skipped tests: 240
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-10T22:23:23Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench · 2022-10-10T23:43:53Z

I'm removing reviewers while the PR is in draft to try and avoid spamming y'all 🙏

modular-magician · 2022-10-11T11:50:15Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

mmv1/products/compute/api.yaml

mmv1/templates/terraform/examples/region_url_map_default_route_action.tf.erb

slevenick · 2022-10-19T22:51:06Z

mmv1/templates/terraform/examples/region_url_map_default_route_action.tf.erb

+  name        = "<%= ctx[:vars]['region_url_map_name'] %>"
+  description = "a description"
+
+  default_route_action {


Can you write a test that updates several of the fields in here (particularly the lists like retry_policy & weighted_backend_services) to add items, remove items and/or remove the list entirely?

Updates on these sorts of fields can be complicated and produce perma-diffs for users depending on how the API is implemented, and we lose a lot of possible fixes once we release the resource with a certain implementation

Will do soon, ~~after the choice about using sets is clearer!~~ after I make the PR conform to google_compute_url_map

Tests added in 06750b7

mmv1/products/compute/api.yaml

…d_services` blocks and nested blocks

modular-magician · 2022-11-07T19:44:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1421 insertions(+), 61 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1421 insertions(+), 61 deletions(-))
TF Validator: Diff ( 3 files changed, 341 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 230 insertions(+))

modular-magician · 2022-11-07T20:29:08Z

Tests analytics

Total tests: 2221
Passed tests 1979
Skipped tests: 239
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeRegionUrlMap_errorWhenUseID

modular-magician · 2022-11-07T20:30:41Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Error message] [Debug log]
TestAccComputeRegionUrlMap_errorWhenUseID[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…te_action` To match UrlMap resource : https://github.com/hashicorp/magic-modules/blob/4f1ef3974f99d6a9efa95ea0284ee831cc63d2f5/mmv1/products/compute/api.yaml#L18556-L18557

…ror_policy`, and`weighted_backend_services` fields within `default_route_action`

modular-magician · 2022-11-08T16:25:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1546 insertions(+), 49 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1546 insertions(+), 49 deletions(-))
TF Validator: Diff ( 3 files changed, 336 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 230 insertions(+))

…ion of this resource

…default_route_action`, add field to `retryPolicy`

SarahFrench · 2022-11-08T16:35:25Z

This resource is a bit of a pain and this PR is a bit messy, apologies!

I've made changes so that this PR adds fields to google_compute_region_url_map in a way that matches the google_compute_url_map resource

RegionUrlMap	UrlMap
weightedBackendServices added in this PR	weightedBackendServices
retryPolicy added in this PR	retryPolicy
requestMirrorPolicy added in this PR	requestMirrorPolicy

modular-magician · 2022-11-08T16:48:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1553 insertions(+), 49 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1553 insertions(+), 49 deletions(-))
TF Validator: Diff ( 3 files changed, 336 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 230 insertions(+))

modular-magician · 2022-11-08T17:40:40Z

Tests analytics

Total tests: 2228
Passed tests 1985
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeForwardingRule_update

modular-magician · 2022-11-08T17:42:30Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

SarahFrench · 2022-11-14T13:41:57Z

Thanks!

…map` resource (GoogleCloudPlatform#6674) * Add `defaultRouteAction.weightedBackendServices[]` to `google_compute_region_url_map` resource Enforce mutual exclusive relationships between `defaultRouteAction.weightedBackendServices[]`, `defaultUrlRedirect` and `defaultService` * Add generated test for `google_compute_region_url_map` resource, including `defaultRouteAction.weightedBackendServices[]` * Add `defaultRouteAction.retryPolicy` to `google_compute_region_url_map` resource, update generated test * Add `defaultRouteAction.requestMirrorPolicy` to `google_compute_region_url_map` resource, update generated test * Add missing field descriptions * Add missing `properties` field from `requestMirrorPolicy` definition * Update example (an generated tests) to have multiple `weighted_backend_services` blocks and nested blocks * Convert `defaultRouteAction.weightedBackendServices` and `defaultRouteAction.weightedBackendServices.headerAction.*` lists to sets, add test showing issue with permadiff * Remove use of sets, to match global version of the resource * Add `conflicts` field between `default_url_redirect` and `default_route_action` To match UrlMap resource : https://github.com/hashicorp/magic-modules/blob/4f1ef3974f99d6a9efa95ea0284ee831cc63d2f5/mmv1/products/compute/api.yaml#L18556-L18557 * Remove validation for field not added in this PR * Update acceptance test to set and update `retry_policy`, `request_mirror_policy`, and`weighted_backend_services` fields within `default_route_action` * Add missing `at_least_one_of` fields, for parity with the global version of this resource * Update `at_least_one_of` field to reference fields currently within `default_route_action`, add field to `retryPolicy`

modular-magician requested a review from ScottSuarez October 10, 2022 21:16

SarahFrench removed the request for review from ScottSuarez October 10, 2022 21:16

modular-magician requested a review from slevenick October 10, 2022 21:17

SarahFrench added 4 commits October 10, 2022 22:19

Add defaultRouteAction.weightedBackendServices[] to `google_compute…

d93dd91

…_region_url_map` resource Enforce mutual exclusive relationships between `defaultRouteAction.weightedBackendServices[]`, `defaultUrlRedirect` and `defaultService`

Add generated test for google_compute_region_url_map resource, incl…

fc4e153

…uding `defaultRouteAction.weightedBackendServices[]`

Add defaultRouteAction.retryPolicy to `google_compute_region_url_ma…

f5f78d6

…p` resource, update generated test

Add defaultRouteAction.requestMirrorPolicy to `google_compute_regio…

919c511

…n_url_map` resource, update generated test

SarahFrench force-pushed the update-regional-url-map branch from 13937e4 to 919c511 Compare October 10, 2022 21:19

SarahFrench removed the request for review from slevenick October 10, 2022 23:43

SarahFrench changed the title ~~Add default_route_action.weighted_backend_services field to google_compute_region_url_map resource~~ Add 3 default_route_action subfields to google_compute_region_url_map resource Oct 10, 2022

SarahFrench mentioned this pull request Oct 11, 2022

Add remaining default_route_action subfields to google_compute_region_url_map resource #6676

Merged

5 tasks

Add missing field descriptions

a84278d

SarahFrench marked this pull request as ready for review October 11, 2022 11:49

modular-magician requested a review from megan07 October 11, 2022 11:50

SarahFrench requested review from slevenick and removed request for megan07 October 11, 2022 11:50

slevenick reviewed Oct 19, 2022

View reviewed changes

Merge branch 'main' into update-regional-url-map

cb075ca

modular-magician requested a review from slevenick November 4, 2022 16:09

SarahFrench commented Nov 4, 2022

View reviewed changes

mmv1/products/compute/api.yaml Show resolved Hide resolved

SarahFrench added 2 commits November 4, 2022 19:55

Add missing properties field from requestMirrorPolicy definition

4f1ef39

Update example (an generated tests) to have multiple `weighted_backen…

2005910

…d_services` blocks and nested blocks

SarahFrench removed the request for review from slevenick November 4, 2022 21:48

SarahFrench added 2 commits November 8, 2022 12:09

Remove use of sets, to match global version of the resource

583d9b1

Add conflicts field between default_url_redirect and `default_rou…

1612d3b

…te_action` To match UrlMap resource : https://github.com/hashicorp/magic-modules/blob/4f1ef3974f99d6a9efa95ea0284ee831cc63d2f5/mmv1/products/compute/api.yaml#L18556-L18557

modular-magician requested a review from slevenick November 8, 2022 12:22

SarahFrench added 2 commits November 8, 2022 13:45

Remove validation for field not added in this PR

d600947

Update acceptance test to set and update retry_policy, `request_mir…

06750b7

…ror_policy`, and`weighted_backend_services` fields within `default_route_action`

SarahFrench added 2 commits November 8, 2022 16:26

Add missing at_least_one_of fields, for parity with the global vers…

4015624

…ion of this resource

Update at_least_one_of field to reference fields currently within `…

b728b85

…default_route_action`, add field to `retryPolicy`

slevenick approved these changes Nov 11, 2022

View reviewed changes

SarahFrench merged commit 7de8791 into GoogleCloudPlatform:main Nov 14, 2022

SarahFrench deleted the update-regional-url-map branch March 26, 2024 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 3 `default_route_action` subfields to `google_compute_region_url_map` resource #6674

Add 3 `default_route_action` subfields to `google_compute_region_url_map` resource #6674

SarahFrench commented Oct 10, 2022 •

edited

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

SarahFrench commented Oct 10, 2022

modular-magician commented Oct 11, 2022

slevenick Oct 19, 2022

SarahFrench Nov 7, 2022 •

edited

SarahFrench Nov 8, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 8, 2022

SarahFrench commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

SarahFrench commented Nov 14, 2022

Add 3 default_route_action subfields to google_compute_region_url_map resource #6674

Add 3 default_route_action subfields to google_compute_region_url_map resource #6674

Conversation

SarahFrench commented Oct 10, 2022 • edited

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

modular-magician commented Oct 10, 2022

Diff report:

modular-magician commented Oct 10, 2022

Tests analytics

Action taken

modular-magician commented Oct 10, 2022

SarahFrench commented Oct 10, 2022

modular-magician commented Oct 11, 2022

slevenick Oct 19, 2022

Choose a reason for hiding this comment

SarahFrench Nov 7, 2022 • edited

Choose a reason for hiding this comment

SarahFrench Nov 8, 2022

Choose a reason for hiding this comment

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 7, 2022

Tests analytics

Action taken

modular-magician commented Nov 7, 2022

modular-magician commented Nov 8, 2022

Diff report

SarahFrench commented Nov 8, 2022

modular-magician commented Nov 8, 2022

Diff report

modular-magician commented Nov 8, 2022

Tests analytics

Action taken

modular-magician commented Nov 8, 2022

SarahFrench commented Nov 14, 2022

Add 3 `default_route_action` subfields to `google_compute_region_url_map` resource #6674

Add 3 `default_route_action` subfields to `google_compute_region_url_map` resource #6674

SarahFrench commented Oct 10, 2022 •

edited

SarahFrench Nov 7, 2022 •

edited