New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly release visible_core_count #6860
Merged
slevenick
merged 2 commits into
GoogleCloudPlatform:main
from
slevenick:ga-vcc-template
Nov 22, 2022
Merged
Correctly release visible_core_count #6860
slevenick
merged 2 commits into
GoogleCloudPlatform:main
from
slevenick:ga-vcc-template
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
approved these changes
Nov 22, 2022
Looks like this fails an existing test (https://ci-oss.hashicorp.engineering/test/3284804160641725973?currentProjectId=GoogleCloud&branch=%3Cdefault%3E) so there's no addtl. test needed to cover. |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerNodePool_withNodeConfig|TestAccLoggingBucketConfigProject_cmekSettings |
This was referenced Nov 22, 2022
googlerjk
pushed a commit
to googlerjk/magic-modules
that referenced
this pull request
Nov 25, 2022
* Correctly release visible_core_count * Add test
kimihrr
pushed a commit
to kimihrr/kimiah-magic-modules
that referenced
this pull request
Dec 6, 2022
* Correctly release visible_core_count * Add test
hao-nan-li
pushed a commit
to hao-nan-li/magic-modules
that referenced
this pull request
Dec 6, 2022
* Correctly release visible_core_count * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#13097
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)