Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly release visible_core_count #6860

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Correctly release visible_core_count #6860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0880ded
Correctly release visible_core_count
slevenick Nov 22, 2022
396812b
Add test
slevenick Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions mmv1/third_party/terraform/resources/resource_compute_instance_template.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,14 +677,12 @@ func resourceComputeInstanceTemplate() *schema.Resource {
ForceNew: true,
Description: `The number of threads per physical core. To disable simultaneous multithreading (SMT) set this to 1. If unset, the maximum number of threads supported per core by the underlying processor is assumed.`,
},
<% unless version == 'ga' -%>
"visible_core_count": {
Type: schema.TypeInt,
Optional: true,
ForceNew: true,
Description: `The number of physical cores to expose to an instance. Multiply by the number of threads per core to compute the total number of virtual CPUs to expose to the instance. If unset, the number of cores is inferred from the instance\'s nominal CPU count and the underlying platform\'s SMT width.`,
},
<% end -%>
},
},
},
Expand Down
2 changes: 0 additions & 2 deletions mmv1/third_party/terraform/tests/resource_compute_instance_template_test.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2536,9 +2536,7 @@ resource "google_compute_instance_template" "foobar" {
advanced_machine_features {
threads_per_core = 1
enable_nested_virtualization = true
<% unless version == "ga" -%>
visible_core_count = 1
<% end -%>
}

scheduling {
Expand Down