Change the type of internal_ips and external_ips to Set instead of List.

[askubis]

Previous bevahiour was causing flaking tests, as List enforces an order, whereas MIG API does not.

fixes hashicorp/terraform-provider-google#13430

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

compute: Fixed problem with ordering in stateful tests of InstanceGroupManager and RegionInstanceGroupManager

[modular-magician]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_external_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_instance_group_manager - reference
• Field stateful_internal_ip changed from TypeList to TypeSet on google_compute_region_instance_group_manager - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2445
Passed tests 2189
Skipped tests: 255
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[slevenick]

Per #7205 (comment) I believe this is a breaking change and we can't do it in a minor release

[askubis]

Sorry, it's my 1st time contributing. IS the process for a major release different? Should I do something differently?

[slevenick]

We just won't be able to merge this change until a major release is imminent, which may not be for several months

[slevenick]

Alternatively as noted in hashicorp/terraform-provider-google#13430 (comment) it may be possible to handle reordering on our side without changing the type to a TypeSet, which would allow the fix to be merged without a breaking change

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

Waiting on major release

[github-actions]

@askubis, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@askubis, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@askubis, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

[askubis]

I'll close this PR, this will be done on the 6.0.0 branch aiming to release Sep'24