Makefile refactoring. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyhg
approved these changes
Nov 14, 2018
testing.Makefile
Outdated
| @@ -76,10 +72,44 @@ testing/marketplace/deployer/envsubst: \ | |||
| .testing/marketplace/deployer/envsubst/standard | |||
|
|
|||
|
|
|||
| .PHONY: testing/all | |||
| testing/all: \ | |||
| .PHONY: testing/integration | |||
There was a problem hiding this comment.
I prefer test/integration and test/py, or tests/integration. testing makes sense in this context since that's the name of the Makefile. Would recommend consider tests--and renaming accordingly.
There was a problem hiding this comment.
Renamed to tests/*.
testing.Makefile
Outdated
| PYTHON_TEST_TARGETS = $(foreach f,$(PYTHON_TEST_DIRS),$(f).__pytest__) | ||
|
|
||
|
|
||
| .PHONY: test/py |
There was a problem hiding this comment.
should be testing/py to match the following target
NimishC
pushed a commit
that referenced
this pull request
Oct 16, 2019
* Makefile refactoring. * Remove references to .build/marketplace/delete_deprecated. * Rename testing* to tests*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved python testing to
testing.Makefileand reformatted dependencies.