adservice - Java 19

[mathieu-benoit]

Java 18 --> Java 19 for adservice.

Java 19 is now GA https://jdk.java.net/19/release-notes (17 is still the LTS, but for our Online Boutique sample apps I don't see any issue to move to the GA version)

Fixing these 2 CVEs:

• CVE-2022-40674 | Critical | 9.8 | Yes | expat
• CVE-2022-43680 | High | 7.5 | Yes | expat

[mathieu-benoit]

This PR is to close the one from Renovate #1130, to do complementary updates + tracking a future update we will need to do as soon as Gradle 7.6 is out to support Java 19, like explained here: gradle/gradle#20372.

Current errors in the CI checks:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'app'.
> Could not open cp_proj generic class cache for build file '/app/build.gradle' (/root/.gradle/caches/7.5.1/scripts/astgkvk0vxvanv977lxl570ge).
   > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 63

[bourgeoisor]

This LGTM, and if we're on 18 we should move to 19, but what was the rationale for moving to 18 in the first place, away from 17 (latest LTS)?

[bourgeoisor]

Looks like Gradle may need to be bumped, this version is from before 19 being GA:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'app'.
> Could not open cp_proj generic class cache for build file '/app/build.gradle' (/root/.gradle/caches/7.5.1/scripts/astgkvk0vxvanv977lxl570ge).
   > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 63

[mathieu-benoit]

Gradle 7.6 is now out and the CI pipeline is leveraging it now: #1302.

Now the issue is at runtime:

- pr1132:pod/adservice-6f5558599b-mg685: container server terminated with exit code 1
      > [adservice-6f5558599b-mg685 server] Could not create logging file: Read-only file system
      > [adservice-6f5558599b-mg685 server] COULD NOT CREATE A LOGGINGFILE 20221129-144421.1!Could not create logging file: Read-only file system
      > [adservice-6f5558599b-mg685 server] COULD NOT CREATE A LOGGINGFILE 20221129-144421.1!Error: LinkageError occurred while loading main class hipstershop.AdService
      > [adservice-6f5558599b-mg685 server] 	java.lang.UnsupportedClassVersionError: hipstershop/AdService has been compiled by a more recent version of the Java Runtime (class file version 63.0), this version of the Java Runtime only recognizes class file versions up to 62.0
 - pr1132:deployment/adservice failed. Error: container server terminated with exit code 1.

[github-actions]

🚲 PR staged at http://35.223.27.27

[mathieu-benoit]

Finally, I just needed to resolve this hipstershop/AdService has been compiled by a more recent version of the Java Runtime (class file version 63.0), this version of the Java Runtime only recognizes class file versions up to 62.0 by using the same version for the 2 stages in the Dockerfile.

Looks like we are now ready to have Java 19 (STS - GA), but your call @NimJay to say if you want it in main branch. Context: 17 is still the LTS, and we are already in 18, moving to 19 fixes 2 CVEs.

[NimJay]

I think newer the version, the better — as long as there's support and it's stable/GA.
So 19 sounds good to me. :)

Thanks, Olivier and Mathieu, for your input.
And thanks, Mathieu, for fixing the issues!