Use kustomize for skaffold local development #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds kustomization.yaml to kubernetes-manifests folder Changes render target in skaffold.yaml to kustomize
|
🚲 PR staged at http://35.202.95.12 |
NimJay
reviewed
Nov 3, 2022
Co-authored-by: Nim Jayawardena <nimjay@google.com>
|
🚲 PR staged at http://35.202.95.12 |
NimJay
approved these changes
Nov 4, 2022
NimJay
approved these changes
Nov 4, 2022
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* Use kustomize for skaffold local development Adds kustomization.yaml to kubernetes-manifests folder Changes render target in skaffold.yaml to kustomize * Update kubernetes-manifests/kustomization.yaml Co-authored-by: Nim Jayawardena <nimjay@google.com> Co-authored-by: Nim Jayawardena <nimjay@google.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds kustomization.yaml to kubernetes-manifests folder Changes render target in skaffold.yaml to kustomize
Background
This change allows use of skaffold for local development with a different kustomize target than the default one in kustomize/
This allows us to keep separate "dev" manifests in kubernetes-manifests/ with clean "release" versions occasionally generated and stored in kustomize/base. That way, when you deploy from kustomize/ you will not get any unrelease development noise/features.
Additional Notes
This might not be an ideal solution, but I believe it is a step in the right direction. Note that kustomize components are all in kustomize/components; there are no separate development and release versions. Perhaps the modules could be moved to a dev folder and copied to kustomize/ on release, or perhaps that is less of a concern than ensuring that release manifests always point to pre-built known images. I'm not sure.
Related PRs or Issues
#1228 is definitely related. Using skaffold profiles might provide a better solution, but I'm not sure that it addresses the release/dev manifest separation discussed in Background.