Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requests and bump node to v 19 in currencyservice #1283

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

xtineskim
Copy link
Contributor

@xtineskim xtineskim commented Nov 21, 2022

Background

Related to #1282 . Attempting to bump the node version

Fixes

#1282

Change Summary

  • Removed requests - a deprecated module which was listed as a dependency in currency service.
  • Bump of the node to v 19.0.0 in currency service

Additional Notes

This is just bumping curreny service

Testing Procedure

Either test locally, or ensure the CI passes!

Related PRs or Issues

@xtineskim xtineskim requested a review from a team as a code owner November 21, 2022 19:25
@github-actions
Copy link

🚲 PR staged at http://34.67.149.96

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates, Christine! 👏
All checks are passing. And the staging URL works. Approved!

@NimJay NimJay merged commit ae12342 into main Nov 21, 2022
@NimJay NimJay deleted the node-bump branch November 21, 2022 19:34
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants