replace patchesStrategicMerge with patches #1689
Conversation
|
R: @NimJay |
|
This pipeline is failing: https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/.github/workflows/kustomize-build-ci.yaml @smeet07 could look into this + add some more context in the description? |
The patchesStrategicMerge has been deprecated and hence needs to be replaced by patches |
|
@bourgeoisor The error suggests that there is some syntax error in https://github.com/smeet07/microservices-demo/blob/patch-2/kustomize/components/cymbal-branding/kustomization.yaml but there isn't any according to me, could you help me find out if there is any |
|
@NimJay , you probably will need to fix the problem with the required code-tests and deployment-tests checks using the recommended technique. |
There was a problem hiding this comment.
the syntax for patches is incorrect. The problem is not only in the cymbal-branding component but in all components that have inline patch.
See examples for inline patching. TL;DR; you need to define a field patch: for each element of the patches list.
I fixed it for you.
* replace patchesStrategicMerge with patches * chore: fix inline patching syntax --------- Co-authored-by: minherz <minherz@gmail.com>
* replace patchesStrategicMerge with patches * chore: fix inline patching syntax --------- Co-authored-by: minherz <minherz@gmail.com>
Background
Fixes
#1564
Change Summary
Additional Notes
Testing Procedure
Related PRs or Issues