Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skaffold.yaml to add gcb build #24

Merged
merged 3 commits into from Aug 21, 2018

Conversation

ocervell
Copy link
Contributor

skaffold run will fail while building the cartservice with a 'No Space Left on Device Error'
Increasing the disk allocated for the build (default 200GB) to get rid of this error.

`skaffold run` will fail while building the `cartservice` with a 'No Space Left on Device Error'
Increasing the disk allocated for the build (default 200GB) to get rid of this error.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2018
@ahmetb
Copy link
Contributor

ahmetb commented Aug 16, 2018

Adding this change forces the skaffold.yaml to force running on GCB which is not something we want.

Instead, can you please do:

# You can also use Google Cloud Builder to build
# the images on the cloud with "skaffold run -p gcb".
profiles:
  gcb:
    build:
      googleCloudBuild: [...]

so that others not using GCB aren't effected?

Default VM disk size is 200 for Cloud Build, we need at least 300 to build all services.
@ocervell
Copy link
Contributor Author

Done, better this way indeed.

Should we mention the build VM disk space needed somewhere in the docs ?

@ahmetb
Copy link
Contributor

ahmetb commented Aug 20, 2018

I think this would be a problem if you're building the cartservice many times, so you have unused layers of it laying around to consume a lot of space. I reckon you're not actively refactoring the cartservice –so not sure why this is happening to you.

I don't understand why ~20 GB (or whatever the GCB default is) isn't enough to build all images once. I've developed most of this demo from scratch on 64GB "docker for mac" with many stale layers laying around for each image, and never ran out of disk.

Is your concern primarily "laptop disk space" or "GCB build machine disk space"?

@ahmetb ahmetb changed the title Update skaffold.yaml Update skaffold.yaml to add gcb build Aug 21, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 21, 2018
@ahmetb
Copy link
Contributor

ahmetb commented Aug 21, 2018

I have annotated the GCB section of the yaml, now merging.

We won't be using this for now, but I'm ok with keeping it to showcase GCB.

@ahmetb ahmetb added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 21, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@ahmetb
Copy link
Contributor

ahmetb commented Aug 21, 2018

Overriding CLA check caused by creating a commit (by me) from the GitHub web UI.

@ahmetb ahmetb merged commit 1d266bf into GoogleCloudPlatform:master Aug 21, 2018
@ocervell ocervell deleted the patch-1 branch August 29, 2018 17:48
@dzuluaga
Copy link

dzuluaga commented Nov 7, 2018

This issue helped me understand why I was getting "No Space Left on Device Error" on this tutorial. Thanks for putting this together!

D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Update skaffold.yaml to add gcb build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants