New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skaffold.yaml to add gcb build #24
Conversation
`skaffold run` will fail while building the `cartservice` with a 'No Space Left on Device Error' Increasing the disk allocated for the build (default 200GB) to get rid of this error.
Adding this change forces the skaffold.yaml to force running on GCB which is not something we want. Instead, can you please do: # You can also use Google Cloud Builder to build
# the images on the cloud with "skaffold run -p gcb".
profiles:
gcb:
build:
googleCloudBuild: [...] so that others not using GCB aren't effected? |
Default VM disk size is 200 for Cloud Build, we need at least 300 to build all services.
Done, better this way indeed. Should we mention the build VM disk space needed somewhere in the docs ? |
I think this would be a problem if you're building the cartservice many times, so you have unused layers of it laying around to consume a lot of space. I reckon you're not actively refactoring the cartservice –so not sure why this is happening to you. I don't understand why ~20 GB (or whatever the GCB default is) isn't enough to build all images once. I've developed most of this demo from scratch on 64GB "docker for mac" with many stale layers laying around for each image, and never ran out of disk. Is your concern primarily "laptop disk space" or "GCB build machine disk space"? |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I have annotated the GCB section of the yaml, now merging. We won't be using this for now, but I'm ok with keeping it to showcase GCB. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
1 similar comment
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Overriding CLA check caused by creating a commit (by me) from the GitHub web UI. |
This issue helped me understand why I was getting "No Space Left on Device Error" on this tutorial. Thanks for putting this together! |
Update skaffold.yaml to add gcb build
skaffold run
will fail while building thecartservice
with a 'No Space Left on Device Error'Increasing the disk allocated for the build (default 200GB) to get rid of this error.