-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds option to disable Stackdriver Export #293
Adds option to disable Stackdriver Export #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I deployed to a fresh cluster and had no issues
I think my main feedback would be: Do not parse booleans. Instead of doing TRACE="False", consider checking for existence of a flag, for example |
^ This alone would simplify a lot of the current code. |
@ahmetb does this look ok to merge? |
Couple nits, otherwise looking good. |
Adds environment variable option to disable Stackdriver export for Metrics and Tracing, along with the option to turn off Stackdriver Profiler and Debugger.
All services still default to
True
for exporting to SD - must manually add the env variables to disable export.Example deployment YAML: