Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating httplib2 to 0.19.0 #710

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

donmccasland
Copy link
Member

Background

Fixing dependabot alert

Change Summary

Updates httplib2 to 0.19.0

@donmccasland donmccasland requested a review from a team as a code owner February 8, 2022 16:21
@xtineskim
Copy link
Contributor

I don't see any changes to the requirements.in file; I ran into this with #695 (review)
tl;dr, instead use the requirements.in as input to pip-compile!

@bourgeoisor
Copy link
Member

Did the requirements.in file change too? If so we should check it in so we can reproduce the .txt

@NimJay
Copy link
Collaborator

NimJay commented Feb 8, 2022

Thanks for catching the missing requirements.in updates, @ckim328!

I'm also wondering why there is no comment from GitHub Actions (e.g., like this one) containing the staging URL.
In the meantime, the staging URL for this pull-request can be found in the GitHub Action logs: http://34.123.56.89 (which seems to be working!)

@donmccasland
Copy link
Member Author

Thanks for catching the missing requirements.in updates, @ckim328!

I'm also wondering why there is no comment from GitHub Actions (e.g., like this one) containing the staging URL. In the meantime, the staging URL for this pull-request can be found in the GitHub Action logs: http://34.123.56.89 (which seems to be working!)

No requirements.in did not change. Just re-running pip-compile gave us an updated httplib2

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NimJay NimJay merged commit 1c601ba into GoogleCloudPlatform:main Feb 8, 2022
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Mar 27, 2022
* Updating httplib2 to 0.19.0

* Using pip-compile requirements.in to generate requirements.txt
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
* Updating httplib2 to 0.19.0

* Using pip-compile requirements.in to generate requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants