cleanup: Update ansi-regex, node-forge, & json-schema in currency and payment service #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚲 PR staged at http://35.188.201.3 |
|
This PR also captures the |
xtineskim
changed the title
xtineskim
changed the title
NimJay
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
- Thanks for this super quick fix, @ckim328!
- I have done a quick test of the staging URL. I played around with the different currencies and made orders/payments. Everything worked as expected!
- I checked the package-lock.json files, and I see that both dependencies (node-forge and ansi-regex) are now updated to non-vulnerable versions.
- I have created Remove
semistandard#712. It might be the case that we could removesemistandardentirely.
Approved!
|
🚲 PR staged at http://35.188.201.3 |
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Mar 27, 2022
Co-authored-by: Nim Jayawardena <nimjay@google.com>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
Co-authored-by: Nim Jayawardena <nimjay@google.com>
This was referenced Mar 22, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Dependabot alerts for ansi-regex indicating
moderate severityin our currency and payment serviceFixes
Relevant CVE description here
Change Summary
I bumped the devDependency semistandard module to "^16.0.1" for both services. Tested it locally, the images built, and it works as expected!
Additional Notes
n/a
Testing Procedure
n/a
Related PRs or Issues
n/a