Refactor old BigQuery samples and add new ones. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ace-n Ready for review. |
| * Calculate the size of the specified dataset. | ||
| * | ||
| * @param {string} datasetId The ID of the dataset. | ||
| * @param {string} projectId The project ID of the dataset. |
There was a problem hiding this comment.
Is this necessarily "the project ID of the dataset"?
|
Clean up the comments/asserts (as we discussed), and then I'll re-review. 😄 |
|
Addressed comments. |
Current coverage is 88.41% (diff: 98.49%)
|
| }); | ||
|
|
||
| it('should handle error', function () { | ||
| var error = 'error'; | ||
| var error = new Error('error'); |
There was a problem hiding this comment.
Did you intend to keep this change?
There was a problem hiding this comment.
Yes, it's definitely more idiomatic for errors to actually be instances of Error.
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.3...v2.3.4) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#186](https://www.github.com/googleapis/nodejs-game-servers/issues/186)) ([99424ec](https://www.github.com/googleapis/nodejs-game-servers/commit/99424ecd0f87341bd4814cdbe092d2820c9a78d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.3...v2.3.4) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#186](https://www.github.com/googleapis/nodejs-game-servers/issues/186)) ([99424ec](https://www.github.com/googleapis/nodejs-game-servers/commit/99424ecd0f87341bd4814cdbe092d2820c9a78d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.3...v2.3.4) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#186](https://www.github.com/googleapis/nodejs-game-servers/issues/186)) ([99424ec](https://www.github.com/googleapis/nodejs-game-servers/commit/99424ecd0f87341bd4814cdbe092d2820c9a78d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
unforced
pushed a commit
that referenced
this pull request
Nov 17, 2022
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
refactor: use execSync for tests #187 automerged by dpebot
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
refactor: use execSync for tests #187 automerged by dpebot
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
irataxy
pushed a commit
that referenced
this pull request
Jan 14, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/nodejs-video-transcoder@v2.1.0...v2.2.0) (2022-06-29) ### Features * support regapic LRO ([#187](googleapis/nodejs-video-transcoder#187)) ([7924434](googleapis/nodejs-video-transcoder@7924434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/nodejs-video-transcoder@v2.1.0...v2.2.0) (2022-06-29) ### Features * support regapic LRO ([#187](googleapis/nodejs-video-transcoder#187)) ([7924434](googleapis/nodejs-video-transcoder@7924434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.