Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dates diff in secs #2135

Conversation

cuonghuynh
Copy link

No description provided.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 20, 2021
@google-cla
Copy link

google-cla bot commented Jan 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 20, 2021
@@ -60,7 +60,7 @@ const createHttpTaskWithToken = async function (
if (convertedDate < currentDate) {
console.error('Scheduled date in the past.');
} else if (convertedDate > currentDate) {
const date_diff_in_seconds = (convertedDate - currentDate) / 1000;
const date_diff_in_seconds = (convertedDate.getTime() - currentDate.getTime()) / 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR; however .getTime() should not be needed, since subtracting Date objects returns the number of milliseconds since the UNIX epoch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree witih @averikitsch and will close this.

@fhinkel fhinkel closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants