Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exemplars should be sorted in Collector exporter #778

Closed
jsuereth opened this issue Dec 14, 2023 · 1 comment · Fixed by #788
Closed

Exemplars should be sorted in Collector exporter #778

jsuereth opened this issue Dec 14, 2023 · 1 comment · Fixed by #788
Labels
bug Something isn't working priority: p2

Comments

@jsuereth
Copy link
Contributor

@franciscovalentecastro discovered in #777 that we need to make sure exemplars are sorted when sending to Cloud Monitoring or the points will be rejected.

We've been lucky so far, as most exemplars have come from explicit bucket histograms, where they are implicitly sorted.

@dashpole dashpole added bug Something isn't working priority: p2 labels Dec 14, 2023
@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Dec 14, 2023

This is the error i got when hooking up the go export (#777) of Exponential Histograms with the Exemplars from the algorithm implemented in open-telemetry/opentelemetry-go#4455.

2023/12/14 19:14:57 rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Field timeSeries[0].points[0].distributionValue had an invalid value: Distribution |bucket_options.exponential_buckets| has out-of-order/duplicate exemplars.
error details: name = Unknown  desc = total_point_count:2 success_point_count:1 errors:{status:{code:3} point_count:1}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: p2
Projects
None yet
3 participants