Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split into 3 commits:
Fix detector
The detector was incorrectly detecting the cloud run platform instead of the cloud functions platform. This is because cloud functions v2 is implemented on top of cloud run. This commit makes the detector check for cloud functions first to fix this issue.
Reorganize e2e-test-server
This commit splits the scenario handler into its own folder. This way, environment variables like
SUBSCRIPTION_MODE
are only checked when using the push/pull server, and don't cause cloud functions tests to fail.Add cloud functions test
A few problems I ran into while getting this to work:
To solve these, we
go mod vendor
the dependencies into the same directory as our cloud function, which copies the files from elsewhere in our repo. We alsozip -r
to ensure the vendor directory is also zipped.