Expand scope of kubernetes monitored resource mapping to include other platforms #683
Conversation
| // Otherwise, it returns the cloud.platform value. | ||
| func getK8sClusterOrCloudPlatform(attrs ReadOnlyAttributes) string { | ||
| if _, cluster := attrs.GetString(string(semconv.K8SClusterNameKey)); cluster { | ||
| return k8sCluster |
There was a problem hiding this comment.
nit: kind of strange to mix platform semantic conventions and other strings. Maybe return semconv.CloudPlatformGCPKubernetesEngine.Value.AsString() here instead?
There was a problem hiding this comment.
Yeah, I thought about that too. I don't think it's perfect either way (felt weird to return the platform as GCP when it could be any k8s).
It's odd to me that there isn't an attribute to indicate generic K8S platform. The best you can do, as far as I can tell, is just infer if k8s.cluster.name is set. And it's not practical to enumerate every k8s-based cloud platform
Codecov Report
@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 69.31% 69.14% -0.17%
==========================================
Files 36 36
Lines 4728 4728
==========================================
- Hits 3277 3269 -8
- Misses 1297 1305 +8
Partials 154 154 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #627
This broadens the exporter's monitored resource mapping to match anything with
k8s.cluster.nameresource attribute to a k8s monitored resource. Usingk8s.cluster.namemeans that any cloud provider k8s platforms like GKE, EKS, or AKS should be identified, as well as non-cloud clusters like local k8s or minikube.This is a change from the previous behavior, in which any non-GKE kubernetes resources were mapped to
generic_node.