Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify non-GKE resources map to k8s_* monitored resources #594

Closed
damemi opened this issue Jul 26, 2023 · 2 comments · Fixed by #724
Closed

Verify non-GKE resources map to k8s_* monitored resources #594

damemi opened this issue Jul 26, 2023 · 2 comments · Fixed by #724
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request good first issue Good for newcomers priority: p2

Comments

@damemi
Copy link
Member

damemi commented Jul 26, 2023

From GoogleCloudPlatform/opentelemetry-operations-go#627, verify that kubernetes resources do not require cloud.platform: gcp_kubernetes_engine to map to k8s Monitored Resources (k8s_container, k8s_pod, etc).

Go exporter/collector fix in GoogleCloudPlatform/opentelemetry-operations-go#683 uses k8s.cluster.name resource attribute to identify a k8s resource. Other languages should be consistent with this.
@aabmass aabmass added enhancement New feature or request good first issue Good for newcomers priority: p2 labels Jul 31, 2023
@aabmass
Copy link
Contributor

aabmass commented Jul 31, 2023

Triaged. If anyone would like to work on this please leave a comment.

@aabmass aabmass added the enhancement accepted An actionable enhancement for which PRs will be accepted label Jul 31, 2023
tkmsaaaam added a commit to tkmsaaaam/opentelemetry-operations-js that referenced this issue May 16, 2024
@tkmsaaaam
Fix GoogleCloudPlatform#594 enable mapping when not gcp kubernetes
9cebe26
@tkmsaaaam tkmsaaaam mentioned this issue May 16, 2024
Merged
4 tasks
@tkmsaaaam
Copy link
Contributor

I created this PR. #724 Please review it.

tkmsaaaam added a commit to tkmsaaaam/opentelemetry-operations-js that referenced this issue May 25, 2024
@tkmsaaaam
fix: GoogleCloudPlatform#594 enable mapping when not gcp kubernetes
3e4b274
aabmass pushed a commit that referenced this issue Jun 3, 2024
@tkmsaaaam
fix: #594 enable mapping when not gcp kubernetes (#724)
f27a9f9 
* fix: #594 enable mapping when not gcp kubernetes

* fix: remove unnecessary nest

* refactor: use map

* fix: remove unnecessary undefined arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request good first issue Good for newcomers priority: p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #594 enable mapping when not gcp kubernetes tkmsaaaam/opentelemetry-operations-js
3 participants
@aabmass @damemi @tkmsaaaam