Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confgenerator: Send Log Pipeline Ping every 10 minutes. #1495

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Nov 6, 2023

Description

Add fluent-bit component that generates a "Ping" LogEntry every 10 minutes. This log verifies the Ops Agent is currently able to send logs correctly to Google Cloud Logging. The resulting LogEntry will follow the Structured Ops Agent Health Logs (#1290) format.

Sample LogEntry

{
  "insertId": "...",
  "jsonPayload": {
    "code": "LogPingOpsAgent"
  },
  "resource": {
    "type": "gce_instance",
    "labels": {
      "instance_id": "...",
      "project_id": "...",
      "zone": "..."
    }
  },
  "timestamp": "2023-11-06T19:12:05.723238757Z",
  "severity": "DEBUG",
  "labels": {
    "agent.googleapis.com/health/schemaVersion": "v1",
    "agent.googleapis.com/health/agentKind": "ops-agent",
    "agent.googleapis.com/health/agentVersion": "2.44.0"
  },
  "logName": "projects/.../logs/ops-agent-health",
  "receiveTimestamp": "2023-11-06T19:12:06.749694991Z"
}

Related issue

b/308825141

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-logging-ping branch 2 times, most recently from df402df to 3587297 Compare November 23, 2023 00:09
@franciscovalentecastro franciscovalentecastro marked this pull request as ready for review November 23, 2023 00:10
@franciscovalentecastro franciscovalentecastro requested review from a team, igorpeshansky and jefferbrecht and removed request for a team and igorpeshansky November 23, 2023 15:06
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 27, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 27, 2023
@franciscovalentecastro
Copy link
Contributor Author

franciscovalentecastro commented Nov 27, 2023

Current State of PR :

  • Synced with @jefferbrecht. Feature code is correct. We need to verify the first appearance of the Ping.
  • Currently the Ping shows 10 minutes after startup, due to how the in_dummy plugin works.
  • Updated the TestLoggingSelfLogs to verify for the ping. In most platforms takes ~13 mins to complete. Currently it is not the longest running test.
  • Created in_dummy: Add flush_on_startup config. fluent/fluent-bit#8222 in upstream fluent-bit to be able to flush on startup the ping and reduce the length of this test (b/319102785).
  • This PR is blocked by the update of the fluent-bit submodule Update fluent-bit to 2.2.0 release. #1513 to 2.20.0+.

@franciscovalentecastro franciscovalentecastro requested review from a team, ridwanmsharif and jefferbrecht and removed request for jefferbrecht and a team January 5, 2024 18:08
@franciscovalentecastro
Copy link
Contributor Author

All test passed (see cec1a95). Rebasing and merging.

@franciscovalentecastro franciscovalentecastro merged commit 1725694 into master Jan 9, 2024
35 of 51 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-logging-ping branch January 9, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants