Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang version used in TestOTLPMetricsGMP test #1509

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Update golang version used in TestOTLPMetricsGMP test #1509

merged 9 commits into from
Nov 16, 2023

Conversation

rafaelwestphal
Copy link
Contributor

@rafaelwestphal rafaelwestphal commented Nov 13, 2023 •
edited

Description

Integration test is failing because of operator now available. Updating golang version to fix it.

Related issue

b/310621875

How has this been tested?

Failing test is now passing

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@rafaelwestphal rafaelwestphal requested review from a team and avilevy18 and removed request for a team November 13, 2023 14:34
@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 13, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 13, 2023
@martijnvans martijnvans mentioned this pull request Nov 14, 2023
Merged
9 tasks
@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 15, 2023
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 16, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 16, 2023
@franciscovalentecastro
Copy link
Contributor

In previous kokoro:force-run Windows built correctly and test passed. The current failure seems unrelated to the PR. Merging PR.

@franciscovalentecastro franciscovalentecastro merged commit c961ab6 into master Nov 16, 2023
67 of 69 checks passed
franciscovalentecastro pushed a commit that referenced this pull request Nov 21, 2023
@rafaelwestphal @franciscovalentecastro
Update golang version used in TestOTLPMetricsGMP test (#1509)
2d984b9 
* Update golang version used in TestOTLPMetricsGMP test

* Building the http-server to reduce boot time

* Prebuilding binary for fast start time
franciscovalentecastro pushed a commit that referenced this pull request Nov 21, 2023
@rafaelwestphal @franciscovalentecastro
Update golang version used in TestOTLPMetricsGMP test (#1509)
d75b3cd 
* Update golang version used in TestOTLPMetricsGMP test

* Building the http-server to reduce boot time

* Prebuilding binary for fast start time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LujieDuan LujieDuan LujieDuan left review comments

@braydonk braydonk braydonk approved these changes

@avilevy18 avilevy18 Awaiting requested review from avilevy18 avilevy18 was automatically assigned from GoogleCloudPlatform/stackdriver-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rafaelwestphal @franciscovalentecastro @LujieDuan @braydonk @martijnvans @stackdriver-instrumentation-release