Testing: update Prometheus tests to go 1.21.4 #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d put the tarball into a different bucket
martijnvans
commented
Nov 14, 2023
| installCmd = fmt.Sprintf(` | ||
| cd (New-TemporaryFile | %% { Remove-Item $_; New-Item -ItemType Directory -Path $_ }) | ||
| Invoke-WebRequest "https://go.dev/dl/go%s.windows-%s.msi" -OutFile golang.msi | ||
| Start-Process msiexec.exe -ArgumentList "/i","golang.msi","/quiet" -Wait `, goVersion, goArch) | ||
| } else { | ||
| installCmd = fmt.Sprintf(` | ||
| set -e | ||
| set -o pipefail |
There was a problem hiding this comment.
I switched this to use RunRemotely because I personally prefer RunRemotely unless you need the extra features of RunScriptRemotely like command line arguments. RunRemotely is also simpler and produces better messages in the logs.
set -e is unnecessary because the command (excluding "set -o pipefail") is only 1 line long. (this applies equally to RunScriptRemotely and RunRemotely). We don't include set -e for other RunRemotely commands so I removed it here.
set -o pipefail is there so that a nonzero exit code from gsutil cp produces an error instead of being ignored. It's a best practice when piping commands together and you need them all to succeed.
martijnvans
requested review from
rafaelwestphal
and removed request for
rafaelwestphal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also provide better instructions for updating it using
mirror_content.sh, which puts the tarball into a different bucket.Also includes a few other mini fixes to installGolang, such as
RunScriptRemotely->RunRemotelyand some comment tweaks.This is a follow up to #1509.
Related issue
b/310621875
How has this been tested?
Checklist: