Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting changes in #1189 and #1188 #1205

Merged
merged 1 commit into from
Oct 15, 2021
Merged

reverting changes in #1189 and #1188 #1205

merged 1 commit into from
Oct 15, 2021

Conversation

jcnars
Copy link
Contributor

@jcnars jcnars commented Oct 15, 2021

It looks like when I onboarded the build cluster, few steps may have been overlooked.
That results in one-off fixes/troubleshooting that's not typical during onboarding.

Hence cleaning up PRs #1189 and #1188 with this PR, so I can start afresh.

@google-oss-robot
Copy link
Collaborator

Hi @jcnars. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link
Member

/ok-to-test

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, jcnars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit bc4c338 into GoogleCloudPlatform:master Oct 15, 2021
@cjwagner
Copy link
Member

This partial revert broke our config validation presubmit: https://oss-prow.knative.dev/view/gs/oss-prow/pr-logs/pull/GoogleCloudPlatform_oss-test-infra/1202/pull-prow-config-validate/1449139391048978432
I'll make a PR to remove the invalid job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants