adds KMS quickstart #296
Merged
adds KMS quickstart #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
approved these changes
Jan 11, 2017
| @@ -0,0 +1,31 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright 2016 Google Inc. | |||
| // Set the required scopes to access the Key Management Service API | ||
| $client->setScopes(array( | ||
| 'https://www.googleapis.com/auth/cloudkms', | ||
| 'https://www.googleapis.com/auth/cloud-platform' |
There was a problem hiding this comment.
Nope, remove https://www.googleapis.com/auth/cloudkms
jmdobry
requested changes
Jan 11, 2017
| $projectId = 'YOUR_PROJECT_ID'; | ||
|
|
||
| # The "global" zone will list all keys, can be a specific zone if desired | ||
| $zone = 'global'; |
There was a problem hiding this comment.
Change variable name throughout from $zone to $location, per GoogleCloudPlatform/python-docs-samples#754
| # Your Google Cloud Platform project ID | ||
| $projectId = 'YOUR_PROJECT_ID'; | ||
|
|
||
| # The "global" zone will list all keys, can be a specific zone if desired |
There was a problem hiding this comment.
Change comment to Lists keys in the "global" location., per GoogleCloudPlatform/python-docs-samples#754
jmdobry
reviewed
Jan 11, 2017
| $kms = new Google_Service_CloudKMS($client); | ||
|
|
||
| // list all key rings for your project | ||
| $keyRings = $kms->projects_locations_keyRings->listProjectsLocationsKeyRings( |
There was a problem hiding this comment.
Last question, does this work? The published discovery doc required that I change the Node.js and Python samples to pass in a full, manually constructed path.
There was a problem hiding this comment.
Had to add the $parent parameter - should work now
jmdobry
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.