Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves Flex helloworld to this repo #938

Merged
merged 10 commits into from
Aug 6, 2019
Merged

Moves Flex helloworld to this repo #938

merged 10 commits into from
Aug 6, 2019

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Aug 2, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2019
@bshaffer bshaffer changed the title Moves the flex helloworld to this repo Moves Flex helloworld to this repo Aug 6, 2019
@bshaffer bshaffer requested a review from tmatsuo August 6, 2019 17:03
tmatsuo
tmatsuo approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you migrated other app to a framework other than silex, should you do the same for this app? It can come with a future PR though.

appengine/flexible/helloworld/test/ControllersTest.php Outdated Show resolved Hide resolved
@bshaffer
Copy link
Contributor Author

bshaffer commented Aug 6, 2019

Agreed about updating from Silex. I have a PR which updates the Bookshelf to be Lumen. We should upgrade all Silex as well with a future PR

@bshaffer bshaffer merged commit 4edb2e4 into master Aug 6, 2019
@bshaffer bshaffer deleted the flex-helloworld branch August 6, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @tmatsuo @googlebot