Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

due to the change of visjs url, change to another cdn of visjs #352

Merged
merged 2 commits into from Dec 28, 2019

Conversation

daviddhc20120601
Copy link
Contributor

fix issue 328 link:#328

due to the change of visjs url, change to another cdn of visjs

from

<script src="http://visjs.org/dist/vis.js"></script>
<link href="http://visjs.org/dist/vis-timeline-graph2d.min.css" rel="stylesheet" type="text/css" />

to

https://cdnjs.cloudflare.com/ajax/libs/vis/4.21.0/vis.js
https://cdnjs.cloudflare.com/ajax/libs/vis/4.21.0/vis.min.css

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 13, 2019
@googlebot googlebot added the cla: no All committers have NOT signed a CLA label Nov 13, 2019
@daviddhc20120601
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@daviddhc20120601
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

#352

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes All committers have signed a CLA and removed cla: no All committers have NOT signed a CLA labels Nov 13, 2019
@stale
Copy link

stale bot commented Dec 28, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale PRs which are > 45 days without activity label Dec 28, 2019
@stale stale bot removed the stale PRs which are > 45 days without activity label Dec 28, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no All committers have NOT signed a CLA and removed cla: yes All committers have signed a CLA labels Dec 28, 2019
@ryanmcdowell ryanmcdowell self-requested a review December 28, 2019 17:58
@ryanmcdowell
Copy link
Contributor

@googlebot I consent

@ryanmcdowell ryanmcdowell added cla: yes All committers have signed a CLA and removed cla: no All committers have NOT signed a CLA labels Dec 28, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@ryanmcdowell ryanmcdowell merged commit 8d5d5d3 into GoogleCloudPlatform:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants