fix(firestore): update query samples to use FieldFilter #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: firestore
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
changed the title
kweinmeister
approved these changes
Jul 11, 2023
rsamborski
approved these changes
Jul 12, 2023
danghai
added a commit
to kernelci/kcidb
that referenced
this pull request
Dec 3, 2023
Fix: #431 UserWarning in build log: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead The filter argument takes BaseFilter class which is an abstract class and it is implemented in FieldFilter. This class can be imported from google.cloud.firestore_v1.base_query Reference: googleapis/python-firestore#705 GoogleCloudPlatform/python-docs-samples#10407
spbnick
pushed a commit
to kernelci/kcidb
that referenced
this pull request
Dec 5, 2023
Fix: #431 UserWarning in build log: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead The filter argument takes BaseFilter class which is an abstract class and it is implemented in FieldFilter. This class can be imported from google.cloud.firestore_v1.base_query Reference: googleapis/python-firestore#705 GoogleCloudPlatform/python-docs-samples#10407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the samples which currently show the following warnings:
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)