-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update firestore filtering #431
Comments
Hello @spbnick, can I work on this? |
Heeey, Maryam! Long time no see 😀 Sure, feel free to pick this up! |
It's been a while 😄, will send a PR soon |
@spbnick I realized I am not getting the same depreciation message as the one above. I am using Python 3.11.6. Does the Python version matter? Or should I focus on fixing the depreciation error I am getting for mine, since I couldn't reproduce yours? |
@mharyam, no, we cannot do anything regarding the deprecation warnings you see, this is for Google to fix, I think. You need a deployment to reproduce this. You could create a Google Cloud project, do a test deployment there, and run the test to see this. I can give you the commands to do this, if you'd like to do that. However, here's an example of this appearing in the wild: https://github.com/kernelci/kcidb/actions/runs/6695988962/job/18193278781#step:8:257 |
Fix: #431 UserWarning in build log: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead The filter argument takes BaseFilter class which is an abstract class and it is implemented in FieldFilter. This class can be imported from google.cloud.firestore_v1.base_query Reference: googleapis/python-firestore#705 GoogleCloudPlatform/python-docs-samples#10407
Fix: #431 UserWarning in build log: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead The filter argument takes BaseFilter class which is an abstract class and it is implemented in FieldFilter. This class can be imported from google.cloud.firestore_v1.base_query Reference: googleapis/python-firestore#705 GoogleCloudPlatform/python-docs-samples#10407
Our tests have started producing a deprecation warning from the Firestore API:
Update the interface we're using so the warning disappears.
The text was updated successfully, but these errors were encountered: