Hello example update #1496

maheshgurav · 2018-05-21T09:14:05Z

No description provided.

googlebot · 2018-05-21T09:14:08Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

sduskis · 2018-05-22T18:12:34Z

@jabubake: This needs a review from your team. I'll also do first pass to make sure that this is right.

maheshgurav · 2018-05-24T02:33:52Z

I signed it!

googlebot · 2018-05-24T02:33:54Z

CLAs look good, thanks!

jabubake · 2018-05-22T18:20:32Z

bigtable/hello/main.py

+    parser = argparse.ArgumentParser(
+        description=__doc__,
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter)
+    parser.add_argument('project_id', help='Your Cloud Platform project ID.')


s/Cloud Platform/Google Cloud Platform/

jabubake · 2018-05-24T05:34:59Z

bigtable/hello/main.py

+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+import os


Please insert an empty line after license

jabubake · 2018-05-24T05:36:03Z

bigtable/hello/main.py

+- Create a Cloud Bigtable cluster.
+  https://cloud.google.com/bigtable/docs/creating-cluster
+- Set your Google Application Default Credentials.
+  https://developers.google.com/identity/protocols/application-default-credentials


Please use the updated auth link: https://cloud.google.com/docs/authentication/getting-started

jabubake · 2018-05-24T05:38:16Z

bigtable/hello/main.py

+
+def main(project_id, instance_id, table_id):
+    # [START connecting_to_bigtable]
+    # The client must be created with admin=True because it will create a


Please update comment to # Set admin=True to create an client that can perform admin tasks like creating a table.

jabubake · 2018-05-24T05:39:34Z

bigtable/hello/main.py

+    # [START creating_a_table]
+    print('Creating the {} table.'.format(table_id))
+    table = instance.table(table_id)
+    table.create()


Handle error if any on table creation.

Can you please explain, only exception handling needs to add or we should add checks like whether a table already exists etc.?

jabubake · 2018-05-24T05:42:34Z

bigtable/hello/main.py

+
+    # [START scanning rows with filter]
+    print('Scanning for all greetings:')
+    rows = table.yield_rows(filter_=CellsRowLimitFilter(1))


A comment / logging statement to what this filter means would be useful.

jabubake · 2018-05-24T05:43:18Z

bigtable/hello/main.py

+        formatter_class=argparse.ArgumentDefaultsHelpFormatter)
+    parser.add_argument('project_id', help='Your Cloud Platform project ID.')
+    parser.add_argument(
+        'instance_id', help='ID of the Cloud Bigtable instance to connect to.')


Your Cloud Bigtable instance ID

jabubake · 2018-05-24T05:44:02Z

bigtable/hello/main.py

+        'instance_id', help='ID of the Cloud Bigtable instance to connect to.')
+    parser.add_argument(
+        '--table',
+        help='Table to create and destroy.',


s/destroy/delete/g

jabubake · 2018-05-24T05:55:32Z

bigtable/hello/main.py

+    # [END deleting_a_table]
+
+
+if __name__ == '__main1__':


s/main1/main/

jabubake · 2018-05-24T05:56:05Z

bigtable/hello/main.py

+    RowSampleFilter, ColumnRangeFilter, SinkFilter, RowKeyRegexFilter,\
+    TimestampRange, ApplyLabelFilter, ColumnQualifierRegexFilter,\
+    CellsRowLimitFilter, CellsColumnLimitFilter, _BoolFilter, ValueRangeFilter
+from datetime import datetime, timezone


ran into issue w/ timezone included on MacOS X. Samples are expected to be compatible with Python 2.7 and 3.4+. I see similar issues on Github that this may not work with 2.7 ?

Yes, issues with Python 2.7.
What I observed was, we need to use datetime.datetime object and the object needs to pass is compatible with Python 3. For now, we removed timestamp thing from code as per comment from Solomon. But this needs to address this issue in Bigtable code if we want to run with Python 2.7.

sduskis · 2018-05-24T20:09:52Z

bigtable/hello/main.py

+        'Hello Python!',
+    ]
+
+    local_timezone = datetime.now(timezone.utc).astimezone().tzinfo


Please remove this. This does not seem to be used anywhere.

sduskis · 2018-05-24T20:13:11Z

bigtable/hello/main.py

+        row.set_cell(
+            column_family_id,
+            column_id,
+            value.encode('utf-8'), timestamp=datetime.now(tz=pytz.timezone('UTC')))


For now, please remove the timestamp. We'll address this later.

- Fixed print statement - Added filter while using read_row function

Added exception handling block while creating table Added method to check whether table already exists Added table already exists check before creating table

sduskis · 2018-06-05T17:53:39Z

bigtable/hello/main.py

+    # [END deleting_a_table]
+
+
+def check_table_already_exists(table_id, instance):


Is there a table.exists() method? If so, please use that instead. If not, then we need to file a feature request in https://github.com/GoogleCloudPlatform/google-cloud-python for that method.

AVaksman · 2018-09-03T14:14:27Z

@sduskis I believe this PR could be closed. Hello World example was updated with #1670

engelke · 2018-11-19T22:29:08Z

Thank you for your submission. Unfortunately, it has been outdated by other code updates since submission, so we are closing it. I hope you continue to contribute to this or other projects.

maheshgurav added 2 commits May 21, 2018 14:29

Updated hello example by adding GC Rules, limits, filters

d6447a1

Removed hard-coded values

3520afc

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 21, 2018

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 24, 2018

jabubake reviewed May 24, 2018

View reviewed changes

sduskis suggested changes May 24, 2018

View reviewed changes

maheshgurav added 5 commits May 25, 2018 20:37

Updated code with resolved comments on pull request 1496

1ba4442

Fixed text issues raised in pull request 1496

468b117

Fixed textual errors

98c8056

- Removed limit usage example from code

2225945

- Fixed print statement - Added filter while using read_row function

Removed getting_all_rows section with read_rows method

00f56a1

Added exception handling block while creating table Added method to check whether table already exists Added table already exists check before creating table

sduskis reviewed Jun 5, 2018

View reviewed changes

engelke closed this Nov 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hello example update #1496

Hello example update #1496

maheshgurav commented May 21, 2018

googlebot commented May 21, 2018

sduskis commented May 22, 2018

maheshgurav commented May 24, 2018

googlebot commented May 24, 2018

jabubake May 22, 2018

jabubake May 24, 2018

jabubake May 24, 2018

jabubake May 24, 2018

jabubake May 24, 2018

maheshgurav May 25, 2018

jabubake May 24, 2018

jabubake May 24, 2018

jabubake May 24, 2018

jabubake May 24, 2018

jabubake May 24, 2018

maheshgurav May 25, 2018

sduskis May 24, 2018

sduskis May 24, 2018

sduskis Jun 5, 2018

AVaksman commented Sep 3, 2018

engelke commented Nov 19, 2018

		# [END deleting_a_table]


		def check_table_already_exists(table_id, instance):

Hello example update #1496

Hello example update #1496

Conversation

maheshgurav commented May 21, 2018

googlebot commented May 21, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

sduskis commented May 22, 2018

maheshgurav commented May 24, 2018

googlebot commented May 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AVaksman commented Sep 3, 2018

engelke commented Nov 19, 2018