Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated appengine/flexible/cloudsql_postgresql samples. #1666

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Aug 28, 2018

Manually updated requirements for appengine/flexible/cloudsql_postgresql. The test seemed to fail the first time because it ran out of space.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2018
@kurtisvg kurtisvg requested a review from frankyn August 28, 2018 20:30
@@ -1,4 +1,4 @@
Flask==0.12.2
Flask==1.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a major version update. This should be okay, but could you verify associated documentation?

Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline, lgtm

@kurtisvg kurtisvg merged commit 96861aa into master Aug 28, 2018
@kurtisvg kurtisvg deleted the req-update branch August 28, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants