Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python Docker tag #2785

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Update python Docker tag #2785

merged 1 commit into from
Feb 7, 2020

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
python final minor 3.6.0 -> 3.8.0b1
python final minor 3.7 -> 3.8

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you tick the rebase/retry checkbox below.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from averikitsch and a team as code owners February 6, 2020 21:28
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2020
@leahecole
Copy link
Collaborator

@averikitsch let me know how you feel about the files that you're an owner of (I'm guessing those are the run ones?) If you're not ready for 3.8 yet that's totally fine

@averikitsch
Copy link
Contributor

Though we don't have full testing for these samples, they should be fine to update. Though tagging @dinagraves for some test failures.

@dinagraves
Copy link
Contributor

3.5 and 2.7 fail b/c of the f-strings. This is expected - as long as it passes on 3.6 and above, it's fine.

@renovate-bot renovate-bot changed the title chore(deps): update python docker tag Update python Docker tag Feb 7, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2020
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Edited - upon further reading I think it's fine to update the custom dockerfiles for appengine + cloudsql) I can address the trace ones if needed, @ZiweiZhao and @DukeNg

trace/cloud-trace-demo-app/app/Dockerfile Show resolved Hide resolved
@leahecole
Copy link
Collaborator

@dinagraves - I added you as a formal reviewer - +1 on the tests - i actually have another PR out rn hoping to fix the CI/CD so it doesn't run on those - if you or @averikitsch could give it the formal approve at some point, that would be much appreciated

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2020
@leahecole leahecole merged commit adff2be into GoogleCloudPlatform:master Feb 7, 2020
@renovate-bot renovate-bot deleted the renovate/docker-python-3.x branch February 7, 2020 18:36
arithmetic1728 pushed a commit to googleapis/python-tasks that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants