Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Depending on pylint>1.8 breaks Python 2 compatibility #23

Closed
pquentin opened this issue Aug 24, 2018 · 3 comments
Closed

Depending on pylint>1.8 breaks Python 2 compatibility #23

pquentin opened this issue Aug 24, 2018 · 3 comments

Comments

@pquentin
Copy link

pquentin commented Aug 24, 2018

pylint 2.0+ dropped Python 2 support, but gcp-devrel-py-tools depends on 'pylint >= 1.8.0'. This is causing the urllib3 CI to fail with Python 2.7.

Is Python 2 intended to be supported? I don't see any PyPI classifiers. I can open a PR to fix the issue by depending on pylint<2.0 for Python 2+.

Thanks!

@pquentin
Copy link
Author

pquentin commented Dec 5, 2018

@theacodes Any thoughts on this issue? Thanks!

@theacodes
Copy link
Contributor

Is Python 2 intended to be supported? I don't see any PyPI classifiers. I can open a PR to fix the issue by depending on pylint<2.0 for Python 2+.

Yeah we have to so that the app engine sdk part will work. To be honest, I think we can drop pylint/make it an optional dependency. I'm not sure any of our projects are really using pylint any more.

@pquentin
Copy link
Author

pquentin commented Oct 8, 2021

This works now, possibly because we're using pip 9+ in our CI.

@pquentin pquentin closed this as completed Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants