Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rubocop #56

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Remove rubocop #56

merged 1 commit into from
Sep 22, 2016

Conversation

beccasaurus
Copy link
Contributor

We keep disabling linting rules for these Ruby samples. See .rubocop.yml

Rubocop is a great tool for enforcing styles in Ruby libraries and applications.

For code samples, however, Rubocop has provided little to no benefit, while requiring configuration modifications frequently to disable more and more rules.

I favor the creation of a simple style guide, à la Github Ruby Style Guide, discussing our sample templates and style guidelines in addition to performing quality code reviews.

Adding this style guide is a high priority. In the meantime, however, I am going to remove Rubocop as a linting tool. The latest BigQuery sample that I've added has many false-positive violations causing me to disable many cops. Instead of continuing down that path, I am removing Rubocop.

This is done as a single commit, incase we want to revert for some reason in the future.

/cc @thagomizer

@beccasaurus beccasaurus merged commit 4573b01 into master Sep 22, 2016
@beccasaurus beccasaurus deleted the remove-rubocop branch September 22, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant