Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep disabling linting rules for these Ruby samples. See .rubocop.yml
Rubocop is a great tool for enforcing styles in Ruby libraries and applications.
For code samples, however, Rubocop has provided little to no benefit, while requiring configuration modifications frequently to disable more and more rules.
I favor the creation of a simple style guide, à la Github Ruby Style Guide, discussing our sample templates and style guidelines in addition to performing quality code reviews.
Adding this style guide is a high priority. In the meantime, however, I am going to remove Rubocop as a linting tool. The latest BigQuery sample that I've added has many false-positive violations causing me to disable many cops. Instead of continuing down that path, I am removing Rubocop.
This is done as a single commit, incase we want to revert for some reason in the future.
/cc @thagomizer