This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Use case insensitive equals in IAM revoke. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
changed the title
tomscript
approved these changes
Jun 13, 2020
| @@ -68,7 +68,7 @@ func TestIAMRevoke(t *testing.T) { | |||
| folderIDs: []string{"folderID"}, | |||
| projectIDs: []string{}, | |||
| externalMembers: []string{"user:tom@gmail.com"}, | |||
There was a problem hiding this comment.
its the external users (finding) that allows caps. initial users on the iam policy are alway slower
$ gcloud projects get-iam-policy tom-foo | grep gmail
- user:my-email@gmail.com
ghost
deleted the
bugfix/iam-revoke-needs-to-check-user-with-case-insensitive
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing an external user from the project IAM policy it is necessary to use a case insensitive equals.
for example, added external user
jane.doe@example.comwould beJane.Doe@example.comin the project policy, which would cause the code not to remove her from the policy.