This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Add info on how to find the findings-project. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
added
bug
tomscript
reviewed
Jun 13, 2020
| @@ -5,7 +5,7 @@ variable "automation-project" { | |||
|
|
|||
| variable "findings-project" { | |||
| type = string | |||
| description = "Project ID where security findings are sent to." | |||
| description = "Project ID where Event Threat Detection security findings are sent to by the Security Command Center. Configured in the Google Cloud Console in Security > Threat Detection." | |||
There was a problem hiding this comment.
if this is unclear to folks maybe the documentation should be also updated?
tomscript
approved these changes
Jun 13, 2020
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The findings-project that need to be configured in the main
variables.tfshould be the one that was Configured in the Google Cloud Console in Security > Threat Detection.The description of the variable did not have information of where to find which project was this.