Return a Promise from report method #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the callback argument from StackdriverErrorReporter report() and sendErrorPayload() and instead return a Promise that resolves once both the stacktrace is generated and the XHR request completes. Update tests to return promises to the framework rather than use the done() callback where possible. Suppress promise rejections in for top level error handlers to avoid potential loops.
These reflect current behaviour and should be updated when the interface is more clearly defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the callback argument from
StackdriverErrorReporterreport()andsendErrorPayload()and instead return a Promise that resolves once both the stacktrace is generated and the XHR request completes.Update tests to return promises to the framework rather than use the
done()callback where possible.Suppress promise rejections in for top level error handlers to avoid potential loops.
Add new tests for XHR errors - these reflect current behaviour and should be updated when the
interface is more clearly defined.