Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a Promise from report method #50

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Return a Promise from report method #50

merged 2 commits into from
Nov 21, 2018

Commits on Nov 20, 2018

  1. Return a Promise from report method 

    Remove the callback argument from StackdriverErrorReporter report()
and sendErrorPayload() and instead return a Promise that resolves
once both the stacktrace is generated and the XHR request completes.

Update tests to return promises to the framework rather than use the
done() callback where possible.

Suppress promise rejections in for top level error handlers to avoid
potential loops.
    @bz2
    bz2 committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    bb2136c View commit details
    Browse the repository at this point in the history

  2. Add new tests for XHR errors 

    These reflect current behaviour and should be updated when the
interface is more clearly defined.
    @bz2
    bz2 committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a07a9fd View commit details
    Browse the repository at this point in the history