Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skips teardown for secure-cloud-func-internal-server #110

Closed
wants to merge 5 commits into from

Conversation

g-awmalik
Copy link

No description provided.

@g-awmalik g-awmalik requested review from prabhu34, gtsorbo and a team as code owners April 2, 2024 16:47
Copy link
Collaborator

@prabhu34 prabhu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build succeeds!

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should open an issue and label this PR as chore: or chore(CI): as this only changes the CI, not the module.

@g-awmalik g-awmalik changed the title fix: skips teardown for secure-cloud-func-internal-server chore: skips teardown for secure-cloud-func-internal-server Apr 2, 2024
@daniel-cit
Copy link
Collaborator

@apeabody Could you please update this PR?

@daniel-cit
Copy link
Collaborator

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .

Is this the original intent ?

@prabhu34
Copy link
Collaborator

prabhu34 commented Apr 5, 2024

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .

Is this the original intent ?

No, definitely not the intent. The teardown was commented out and left stale resources in the project. Was unable to proceed further and I had to comment the entire secure-cloud-func-internal-server to debug the issue.

@apeabody
Copy link
Contributor

@g-awmalik - The added retry during the teardown appears to have worked around the issue: #112

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jun 15, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants