-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skips teardown for secure-cloud-func-internal-server #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the build succeeds!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should open an issue and label this PR as chore:
or chore(CI):
as this only changes the CI, not the module.
@apeabody Could you please update this PR? |
@g-awmalik looking at the changes, this Pull Request is skipping the whole Is this the original intent ? |
@g-awmalik to skip the teardown phaser of the secure examples wouldn't be enough to comment out this ones: |
No, definitely not the intent. The teardown was commented out and left stale resources in the project. Was unable to proceed further and I had to comment the entire |
@g-awmalik - The added retry during the teardown appears to have worked around the issue: #112 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
No description provided.