-
Notifications
You must be signed in to change notification settings - Fork 5
barebones mvp #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments - overall it looks great from the Terraform side of things. I'm not a MongoDB Atlas expert, but this looks reasonable. Nice job!
(moving this conversation out of unrelated thread) @subfuzion said:
I think in this case it makes sense to keep everything together. Let's keep it all here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of thoughts.
|
||
for_each = toset([ | ||
"run", | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks a little silly right now but we're going to be enabling other services down the road and so I went with this construct now in anticipation of that
After successfully running Error output
Is this expected? Should anything be cleaned up from previous state, or do we need to tell users best to start from a fresh clone? |
Using the same clone after
Will try again from a fresh clone. |
That's very strange. Did it successfully create a project before failing? Does the project ID from the error output match the ID of the newly created project? Does that project have a billing account assigned if you check in the console or with gcloud? |
Using the same |
huh. that's interesting. it's possible it was transient or it's possible that it's another graph traversal thing, but it's hard for me to imagine what could have gone wrong unless the destroy was interrupted. Give it another shot and if it fails again, ping me so we can debug |
I updated the detail in my comment to show the full output before the error. |
Yeah, wow, I don't understand what happened there. Maybe @villasenor or @mikegcoleman might have an idea? If it happens again, let's hop on a call so we can look at it together. |
Just a weird anomaly, I guess? I just successfully twice ran |
After running Even after waiting for a while, I can see all the "destroyed" projects still listed in the console and can navigate to them. I know that projects are scheduled for deletion after 30 days, but after shutting one down access to the project should be lost immediately. Is this not the case? |
I think that's an artifact of how the console works. Several of my old projects are listed in there as well, but I can also see them on the pending deletion page. Check to see if they're listed there, and if so I think everything is working as expected. |
It's super confusing. I'll add a note to the readme mentioning that you might see the project stick around for a while, and giving a link to the pending deletion page for confirmation. Good find! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really nice work!
This PR will contain the extremely limited MVP we discussed using as a starting point. Opening the PR now so we have a place to discuss while I continue work. We can consider this exercise successful when a user can:
terraform apply
terraform destroy
to clean upThings it'll do:
Things it won't do: